-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local archive mode (fixes #6) #88
Closed
Closed
Changes from 25 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
fbca19a
local/remote switch for rsync
jkbecker a39f39a
fix local rsync dest
jkbecker fc7ea41
add notes to config.yaml
jkbecker f3281d6
Merge branch 'development' of github.com:ericaltendorf/plotman into a…
jkbecker ad86f13
Merge branch 'setup' into archivelocal
jkbecker 715267b
Merge branch 'setup' of github.com:jkbecker/plotman into archivelocal
jkbecker 6882e10
Merge branch 'development' of github.com:jkbecker/plotman into archiv…
jkbecker 829661c
Update config.yaml
jkbecker aae3654
Update src/plotman/archive.py
jkbecker 9f205df
Merge branch 'development' of github.com:ericaltendorf/plotman into a…
jkbecker c570f7c
Merge branch 'archivelocal' of github.com:jkbecker/plotman into archi…
jkbecker c7d8ce2
adapt config template
jkbecker 68b683f
adapt error message
jkbecker 9d5ae8a
doc fix
jkbecker 2d917fa
whitespace, defaults
jkbecker 43ead3d
Update src/plotman/configuration.py
jkbecker 4aee539
Merge branch 'development' into archivelocal
altendky 194dc6d
Update src/plotman/configuration.py
jkbecker c5d5ad6
Update src/plotman/archive.py
jkbecker 59de0c6
Update src/plotman/archive.py
altendky 7f15c43
Merge branch 'development' of github.com:ericaltendorf/plotman into a…
jkbecker 11d06a7
new config file format supporting local archive mode
jkbecker 6df447e
prepare for legacy vs extendable new configs
jkbecker b97c385
merging
jkbecker 4c92cb1
better example value for local mode
jkbecker 57ebfe5
some archive tests
jkbecker 160b3f9
rsync_dest -> arch_dest refactoring
jkbecker fff7c22
Merge branch 'development' into archivelocal
altendky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, my thought here is to:
rsync
since we need to use it to identify the process (maybe don't separate it though?).df
format.Since we already depended on the shell and are now exposing it to the user hazarding even more dependence and expectations, we should allow configuration of what shell (generally any command, even Python) will interpret the command.
Now that I've written this up, I think I roughly create a CI run step... Configurable shell, environment variables, and commands... Anyways.
Not addressed or checked points:
df
and block size andK
and...shell
like Python, or really just in general.As an example to implement the present
rsyncd
functionality, maybe:(I'm sure
awk
cangrep
but I'm lazy at the moment and like stacking. It's the UNIX way. And this is about the idea at this point...)Or for local rsync:
(yeah, some of those slashes are not mandatory but duplicates are ignored so easiest to add extras and make things read sensibly...)
Maybe this is wonderfully controllable. Maybe this is silly. Maybe we can go in this direction and leave out complexities like the configurable shell, just mandate bash. So, maybe this is a more sensible step down the path.