Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce black #821

Merged
merged 10 commits into from
Aug 29, 2021
Merged

introduce black #821

merged 10 commits into from
Aug 29, 2021

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Jul 2, 2021

Draft for:

  • Actually formatting the code (soon...)

@altendky altendky marked this pull request as draft July 2, 2021 03:32
@altendky
Copy link
Collaborator Author

altendky commented Jul 2, 2021

The message below is intended to be placed in each open PR prior to merging to notify the contributors about this change and to offer to help deal with it.


"Soon" we will be using Black to format the code (#821). This isn't because I'm a super big fan of the actual formatting but rather because it is a well accepted formatter that gets mostly tidy code and avoids discussion and thinking about how to format stuff.

I understand that this can be a hassle for outstanding branches. I apologize for this hassle and am happy to let you handle it yourself, to help you through handling it, or just to update your branch for you. Just let me know if you want me to do something about it.

@altendky altendky marked this pull request as ready for review August 29, 2021 01:10
@altendky altendky merged commit bc48154 into ericaltendorf:development Aug 29, 2021
@altendky altendky deleted the black branch August 29, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant