Generalized plot size from K32 to any size of K #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
requested changes
Jun 23, 2021
| @@ -96,7 +96,7 @@ def spawn_archive_process(dir_cfg: configuration.Directories, arch_cfg: configur | |||
|
|
|||
| def compute_priority(phase: job.Phase, gb_free: float, n_plots: int) -> int: | |||
| # All these values are designed around dst buffer dirs of about | |||
| # ~2TB size and containing k32 plots. TODO: Generalize, and | |||
| # ~2TB size and containing k plots. TODO: Generalize, and | |||
There was a problem hiding this comment.
I suspect this is still a valid reference to k32.
Suggested change
| # ~2TB size and containing k plots. TODO: Generalize, and | |
| # ~2TB size and containing k32 plots. TODO: Generalize, and |
| @@ -45,15 +45,15 @@ def test_columns() -> None: | |||
| [ 1 ], | |||
| [ 2 ] ] ) | |||
|
|
|||
| def test_list_k32_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: | |||
| def test_list_k_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: | |||
There was a problem hiding this comment.
Could you add test files for another size or two?
Suggested change
| def test_list_k_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: | |
| def test_list_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: |
| @@ -54,18 +51,19 @@ def split_path_prefix(items: typing.List[str]) -> typing.Tuple[str, typing.List[ | |||
| remainders = [ os.path.relpath(i, prefix) for i in items ] | |||
| return (prefix, remainders) | |||
|
|
|||
| def list_k32_plots(d: str) -> typing.List[str]: | |||
| 'List completed k32 plots in a directory (not recursive)' | |||
| def list_k_plots(d: str) -> typing.List[str]: | |||
There was a problem hiding this comment.
Suggested change
| def list_k_plots(d: str) -> typing.List[str]: | |
| def list_plots(d: str) -> typing.List[str]: |
altendky
added a commit
to altendky/plotman
that referenced
this pull request
Jun 29, 2021
|
Suggested changes submitted in grupoxch#1. |
Merged
|
Alrighty, since I can't edit this even to update it, I'll just merge #814 which includes all your commits from here. It just won't show the clearest record of your contribution here in the PRs. Sorry about that. |
|
Oh, and thanks again for your contribution here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalized plot size from K32 to any size of K
plotman interactivereports correct number of plots (not only k32)plotman archivecan find and archive plots of any size