Update archive.py #550
Closed
Update archive.py #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a / who made disk space on archive not functioning. Corrected the rsync url so it do not look for 12000 folder and removed rsync:// to get it to work at the different locations I tested the code.
|
While this may help your case, it breaks other cases. See #627 for a rework of the archival system that allows customization. Maybe we can merge it in the next few days... Hopefully... |
|
If the new archival approach isn't flexible enough for your needs then let's discuss opportunities to improve it. At this point this PR is not applicable since the code has been significantly reworked. Thanks for your effort on the project and my apologies for my slowness in handling contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed a / who made disk space on archive not functioning.
Corrected the rsync url so it do not look for 12000 folder and removed rsync:// to get it to work at the different locations I tested the code.