Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.3 #326

Merged
merged 173 commits into from
May 12, 2021
Merged

Release v0.3 #326

merged 173 commits into from
May 12, 2021

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented May 11, 2021

Draft for:

altendky and others added 30 commits April 15, 2021 23:10
…ay message into the log if it isn't a stagger
The official macOS dmg installation makes `chia` available as a standalone binary. That means the `cmdline` does not include `python` in the first position. This commit updates the cmdline parsing logic to allow for `chia` binaries like this.
the arguments passed to this function looked like this on OSX:

`['/Library/Frameworks/Python.framework/Versions/3.9/Resources/Python.app/Contents/MacOS/Python', '/Users/chia/chia-blockchain/venv/bin/chia', 'plots', 'create', '-k', '32', '-r', '2', '-u', '128', '-b', '4608', '-t', '/Volumes/plotting2tb', '-d', '/Volumes/16tb']`

The first argument did not contain a lowercase 'python', so we can lowercase the string before comparison to make the check work more generally.
@altendky altendky requested a review from ericaltendorf May 11, 2021 01:24
Copy link
Owner

@ericaltendorf ericaltendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a cursory review to just see what all is included. Looks fine.

@altendky altendky marked this pull request as ready for review May 12, 2021 13:43
@altendky altendky merged commit e259507 into ericaltendorf:main May 12, 2021
@altendky altendky deleted the release/v0.3 branch May 12, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.