Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explain failure to open new log files #219

Merged
merged 2 commits into from
May 6, 2021
Merged

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented May 3, 2021

I specifically chose this explanatory error over just creating the directory. Since the common cause is not having created the directory, or having misconfigured the path, this should only generally happen 'once'. As such, retaining the reminder in case of misconfiguration seems sufficiently useful to overcome the hassle in cases where the directory just hadn't been created.

Draft for:

  • Self testing

@altendky altendky marked this pull request as ready for review May 6, 2021 23:34
@altendky altendky merged commit 3514c12 into development May 6, 2021
@altendky altendky deleted the altendky-patch-2 branch May 6, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants