Improve compatibility and precision of date information in log filenames #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There a few reasons that the current log filenames may not be ideal: 1) They contain `:` which breaks in Windows and is shown as `/` in OSX GUI ([ericaltendorf#144](ericaltendorf#144)) 2) They don't contain any more precision than seconds, so with many concurrent plots being created (or error situations), naming collisions can occur 3) They don't contain any timezone information which makes them not fully comprehensive This potentially closes ericaltendorf#144 Note: As discussed on chat with @altendky, we settled on `+HH_MM` / `-HH_MM` for the timezone part (`±[hh]:[mm]` with the same `:` -> `_` done for times). it seems that `strftime` provides the offset as one component via `%z`, without the option to use a `HH:MM` format. For now I have left it without a separator, but it would be trivial to insert a `_` if it is desired. Thoughts?
BasilHorowt
force-pushed
the
improve_log_format
branch
from
fa6657e to
2e72254
Compare
altendky
reviewed
Apr 28, 2021
Co-authored-by: Kyle Altendorf <[email protected]>
altendky
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There a few reasons that the current log filenames may not be ideal:
:which breaks in Windows and is shown as/in OSX GUI (#144)This potentially closes #144
Note: As discussed on chat with @altendky, we settled on
+HH_MM/-HH_MMfor the timezone part (±[hh]:[mm]with the same:->_done for times). it seems thatstrftimeprovides the offset as one component via%z, without the option to use aHH:MMformat. For now I have left it without a separator, but it would be trivial to insert a_if it is desired. Thoughts?