Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default config.yaml values #139

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Conversation

cciollaro
Copy link
Contributor

obviously we can't provide a config.yaml that works for everyone, but at this point bitfield is going to be better for the vast majority of people and the recommended max memory value (from the changelog at least) is 3389

@BasilHorowt
Copy link
Collaborator

Nice! What's the thinking on the default threads being so high vs chia's defaults? Wonder if it is more intuitive to have all the pass-through options match up with the chia defaults?

@altendky
Copy link
Collaborator

I'm not quite sure what to do here. :] Changelog says 3389 but cli defaults to 4608. Threads default going down to 4 or 2 (the cli default) makes sense to me. What do you think @cciollaro? The suggestion of just tracking the chia defaults sounds good to me. Less to think about, less to debate. They're mostly just an example file anyways, not any actual recommendation since that all depends.

@cciollaro
Copy link
Contributor Author

cciollaro commented Apr 22, 2021

totally agreed. these values are just placeholders and aligning with the command defaults simplifies things. I'll push an update to match the CLI.

as an aside, I made a small PR against chia to see if it makes sense to change the default there Chia-Network/chia-blockchain#2320

Copy link
Collaborator

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cciollaro, thanks for the help getting this up to date.

@altendky altendky merged commit fa3f22c into ericaltendorf:main Apr 22, 2021
BasilHorowt added a commit to BasilHorowt/plotman that referenced this pull request Apr 25, 2021
As per the [previous PR](ericaltendorf#139), Plotman's default config should track the default Chia options to make things simpler.  As per 1.1.2, Chia actually defaults to 3389 for the buffer: Chia-Network/chia-blockchain@d0649fb
hqc-destroy pushed a commit to hqc-destroy/getiwn that referenced this pull request Jun 2, 2021
As per the [previous PR](ericaltendorf/plotman#139), Plotman's default config should track the default Chia options to make things simpler.  As per 1.1.2, Chia actually defaults to 3389 for the buffer: Chia-Network/chia-blockchain@d0649fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants