-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update default config.yaml values #139
Conversation
Nice! What's the thinking on the default threads being so high vs chia's defaults? Wonder if it is more intuitive to have all the pass-through options match up with the chia defaults? |
I'm not quite sure what to do here. |
totally agreed. these values are just placeholders and aligning with the command defaults simplifies things. I'll push an update to match the CLI. as an aside, I made a small PR against chia to see if it makes sense to change the default there Chia-Network/chia-blockchain#2320 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cciollaro, thanks for the help getting this up to date.
As per the [previous PR](ericaltendorf#139), Plotman's default config should track the default Chia options to make things simpler. As per 1.1.2, Chia actually defaults to 3389 for the buffer: Chia-Network/chia-blockchain@d0649fb
As per the [previous PR](ericaltendorf/plotman#139), Plotman's default config should track the default Chia options to make things simpler. As per 1.1.2, Chia actually defaults to 3389 for the buffer: Chia-Network/chia-blockchain@d0649fb
obviously we can't provide a config.yaml that works for everyone, but at this point bitfield is going to be better for the vast majority of people and the recommended max memory value (from the changelog at least) is 3389