Log instances of delays due to resource limitations and their causes #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay message into the log if it isn't a stagger
altendky
reviewed
Apr 22, 2021
There was a problem hiding this comment.
@ericaltendorf, looks ok to me. Any concerns adding the stagger info to the other statuses?
| log.log(msg) | ||
| plotting_status = '<just started job>' | ||
| jobs = Job.get_running_jobs(cfg.directories.log, cached_jobs=jobs) | ||
| else: | ||
| # If a plot is delayed for any reason other than stagger, log it | ||
| if msg.find("stagger") < 0: | ||
| aging_reason = msg |
There was a problem hiding this comment.
So ... when we start a new plot job, we'll log the reason it had been delayed? That could be useful.
There was a problem hiding this comment.
It has helped me with tuning my machines by suggesting what resources are lacking. The only downside that I have encountered is that the Log: count message no longer reflects the total number of jobs launched by plotman since delay messages are also counted.
ericaltendorf
approved these changes
Apr 30, 2021
|
@13thProgression, thanks for joining the ranks of plotman developers. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
Include job age any time that a plot is held off
Insert the last delay message into the log if it isn't a standard stagger delay