[RUNTIME] Remove header dependency on private header (#163)

eric-haibin-lin · Oct 9, 2017 · ddd78c9 · ddd78c9
1 parent d78387e
commit ddd78c9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/docs/how_to/install.md b/docs/how_to/install.md
@@ -16,7 +16,8 @@ git submodule init
 git submodule update --recursive
 ```
 
-NNVM compiler depend on TVM and TOPI, so make sure you install them by following [TVM document](http://docs.tvmlang.org/)
+NNVM compiler depend on TVM and TOPI, so make sure you install them by following [TVM document](http://docs.tvmlang.org/).
+Note that it is necessary to build TVM with LLVM support to take full benefit of NNVM compiler.
 
 ## Contents
 - [Build the Shared Library](#build-the-shared-library)

diff --git a/src/compiler/graph_runtime.cc b/src/compiler/graph_runtime.cc
@@ -15,8 +15,6 @@ namespace compiler {
 using tvm::runtime::TVMArgs;
 using tvm::runtime::TVMRetValue;
 using tvm::runtime::PackedFunc;
-using tvm::runtime::kTVMNDArrayMagic;
-using tvm::runtime::kTVMNDArrayListMagic;
 
 DMLC_REGISTER_PARAMETER(TVMOpParam);
 

diff --git a/src/compiler/graph_runtime.h b/src/compiler/graph_runtime.h
@@ -9,11 +9,15 @@
 #include <nnvm/graph.h>
 #include <vector>
 #include <string>
-#include "../../tvm/src/runtime/graph/graph_runtime.h"
 
 namespace nnvm {
 namespace compiler {
 
+/*! \brief Magic number for NDArray file */
+constexpr uint64_t kTVMNDArrayMagic = 0xDD5E40F096B4A13F;
+/*! \brief Magic number for NDArray list file  */
+constexpr uint64_t kTVMNDArrayListMagic = 0xF7E58D4F05049CB7;
+
 struct TVMOpParam : public dmlc::Parameter<TVMOpParam> {
   std::string func_name;
   uint32_t num_inputs;