Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major Refactors #82

Merged
merged 9 commits into from
May 18, 2024
Merged

Major Refactors #82

merged 9 commits into from
May 18, 2024

Conversation

erhant
Copy link
Owner

@erhant erhant commented May 15, 2024 •
edited
Loading

  • Use pnpm instead of yarn
  • Use jest instead of mocha
  • Group all testing stuff under the tests folder. Only the src and tests should be at the top level, along with the circomkit.json.
  • Resolves Use yargs for the CLI? #47 : Will use commander
  • Refactor Circomkit functions for better modularism & readability
  • Move SnarkJS to peer-dependency
  • Resolves CLI command circomkit list #68 by adding list CLI command
  • Resolves Better builds #81 using pkgroll
  • Renamed clean command to clear
  • No default input argument for CLI
  • Resolves ProofTester type fixes #52 with function overloading
  • Added thank-you message to BuidlGuidl ❤️
  • Removed redundant hardhat packages
  • Removed init command, will instead create a create-circomkit package so that npm init circomkit works

@erhant erhant self-assigned this May 15, 2024
@erhant erhant added bug Something isn't working enhancement New feature or request labels May 15, 2024
@erhant erhant marked this pull request as ready for review May 18, 2024 18:47
@erhant erhant merged commit f210e06 into main May 18, 2024
1 check passed
@erhant erhant deleted the major-rfk branch August 5, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erhant erhant

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better builds CLI command circomkit list ProofTester type fixes Use yargs for the CLI?
1 participant
@erhant