Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced sigma-data module #924

Merged
merged 50 commits into from
Oct 31, 2023
Merged

Introduced sigma-data module #924

merged 50 commits into from
Oct 31, 2023

Conversation

aslesarenko
Copy link
Member

@aslesarenko aslesarenko commented Oct 5, 2023

In this PR:

@aslesarenko aslesarenko changed the base branch from core-serializers2 to v5.0.13-RC October 21, 2023 14:57
@aslesarenko aslesarenko changed the title Towards sigma-data module Introduced sigma-data module Oct 25, 2023
@aslesarenko aslesarenko marked this pull request as ready for review October 25, 2023 08:40
import scala.annotation.nowarn
import scala.reflect.classTag

object defs {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defs name is not descriptive, Scala code conventions not followed, ScalaDoc missed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScalaDocs missed in the class

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please suggest a name.
  2. Which exactly conventions not followed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without ScalaDocs I can't really answer (1), on (2), naming could be ok actually if object is mimicking a package, but hard to say if this is the case, again, without description

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, renamed to syntax and added ScalaDocs

@@ -0,0 +1,15 @@
package sigma.utils

object Overloading {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScalaDocs missed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class turns out to be duplicated, removed.

package sigma.ast

import sigma.Evaluation
import sigma.ast.SType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

import sigma.ast.SType
import sigma.data.Iso
import sigma.js.{Type, Value}
import sigma.ast.Constant
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@kushti
Copy link
Member

kushti commented Oct 27, 2023

Unused code after this PR:

  /** Helper extractor to match SigmaProp values and extract ProveDlog out of it. */
  object ProveDlogProp {
    def unapply(p: SigmaProp): Option[ProveDlog] = SigmaDsl.toSigmaBoolean(p) match {
      case d: ProveDlog => Some(d)
      case _ => None
    }
  }

@aslesarenko aslesarenko merged commit 90c51a0 into v5.0.13-RC Oct 31, 2023
4 checks passed
@aslesarenko aslesarenko deleted the towards-data-module branch May 1, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants