-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced sigma-data module #924
Conversation
…er moved to sigma.ast
import scala.annotation.nowarn | ||
import scala.reflect.classTag | ||
|
||
object defs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defs
name is not descriptive, Scala code conventions not followed, ScalaDoc missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScalaDocs missed in the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please suggest a name.
- Which exactly conventions not followed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without ScalaDocs I can't really answer (1), on (2), naming could be ok actually if object is mimicking a package, but hard to say if this is the case, again, without description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, renamed to syntax
and added ScalaDocs
@@ -0,0 +1,15 @@ | |||
package sigma.utils | |||
|
|||
object Overloading { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScalaDocs missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class turns out to be duplicated, removed.
package sigma.ast | ||
|
||
import sigma.Evaluation | ||
import sigma.ast.SType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
import sigma.ast.SType | ||
import sigma.data.Iso | ||
import sigma.js.{Type, Value} | ||
import sigma.ast.Constant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Unused code after this PR:
|
In this PR:
sigma.ast
package ofdata
module