Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5.x] Refactor tests #802

Merged
merged 18 commits into from
Dec 13, 2022
Merged

[v5.x] Refactor tests #802

merged 18 commits into from
Dec 13, 2022

Conversation

aslesarenko
Copy link
Member

@aslesarenko aslesarenko commented May 15, 2022

In this PR:

  • test harness updated to reflect removal of v4.x interpreter
  • more test cases added to cover possible MethodCalls in ErgoTree for some operations
  • more unused code removed

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #802 (f380584) into v5.0.1-RC (5fb56d0) will decrease coverage by 9.23%.
The diff coverage is 94.11%.

@@              Coverage Diff              @@
##           v5.0.1-RC     #802      +/-   ##
=============================================
- Coverage      71.75%   62.52%   -9.24%     
=============================================
  Files            247      247              
  Lines          19098    18626     -472     
  Branches         628      620       -8     
=============================================
- Hits           13704    11645    -2059     
- Misses          5394     6981    +1587     
Impacted Files Coverage Δ
.../org/ergoplatform/validation/ValidationRules.scala 82.05% <ø> (-10.49%) ⬇️
...te/src/main/scala/sigmastate/eval/Evaluation.scala 53.06% <ø> (-13.79%) ⬇️
...ate/src/main/scala/sigmastate/eval/IRContext.scala 84.61% <75.00%> (+13.56%) ⬆️
...src/main/scala/sigmastate/eval/GraphBuilding.scala 95.38% <100.00%> (-1.63%) ⬇️
.../src/main/scala/sigmastate/eval/TreeBuilding.scala 93.53% <100.00%> (-0.47%) ⬇️
...src/main/scala/sigmastate/lang/SigmaCompiler.scala 100.00% <100.00%> (ø)
.../src/main/scala/sigmastate/eval/CostingRules.scala 14.80% <0.00%> (-84.30%) ⬇️
...rc/main/scala/sigmastate/eval/RuntimeCosting.scala 17.97% <0.00%> (-72.45%) ⬇️
...ain/scala/sigmastate/eval/CompiletimeCosting.scala 26.00% <0.00%> (-68.00%) ⬇️
...in/scala/sigmastate/utxo/ComplexityTableStat.scala 35.71% <0.00%> (-64.29%) ⬇️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aslesarenko aslesarenko added this to the v5.x milestone May 17, 2022
@aslesarenko aslesarenko marked this pull request as ready for review May 18, 2022 12:08
@aslesarenko aslesarenko requested a review from kushti May 18, 2022 12:08
…efactor-tests

# Conflicts:
#	sigmastate/src/main/scala/sigmastate/eval/IRContext.scala
#	sigmastate/src/main/scala/sigmastate/lang/SigmaCompiler.scala
#	sigmastate/src/test/scala/sigmastate/TestsBase.scala
#	sigmastate/src/test/scala/special/sigma/SigmaDslSpecification.scala
Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ScalaDoc for TreeBuilding also.

Evaluation is not descriptive enough name I guess

Please specify in ScalaDoc comments whether classes belong to frontend compiler or tree interpreter.

@aslesarenko aslesarenko changed the base branch from v5.x-graph-building to v5.0.1-RC December 1, 2022 13:43
@aslesarenko
Copy link
Member Author

aslesarenko commented Dec 1, 2022

Please specify in ScalaDoc comments whether classes belong to frontend compiler or tree interpreter.

@kushti in #827 and #833 the consensus code is moved into separate module which doesn't depend on both compiler and graph-IR code. See interpreter and sc (aka sigma compiler) modules.

@aslesarenko aslesarenko changed the title [v5.0.1] Refactor tests [v5.x] Refactor tests Dec 1, 2022
@aslesarenko aslesarenko merged commit d33ab7c into v5.0.1-RC Dec 13, 2022
@aslesarenko aslesarenko deleted the v5.x-refactor-tests branch December 13, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants