[DEMO] V5.0.21 rebased #2136
Closed
[DEMO] V5.0.21 rebased #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add changes to ergo-core readme
extract PoPowAlgosSpec -> PoPowAlgosWithDBSpec extract SerializationTest -> SerializationCoreTest extract JsonSerializationSpec -> JsonSerializationCoreSpec move scorex.testkit.SerializationTests -> ergo-core/org.ergoplatform/utils NiPoPoWVerifierSpec has to stay in node's test since ChainGenerators it requires uses ErgoHistory Create ChainSettingsReader in ergocore Refactor generators to use Object instead of trait. To avoid OOP inheritance spagetti Remove scores.testkit.CoreGenerators Move scorex.testkit.generators.ObjectGenerators -> ergo-core/org.ergoplatform.utils.generators.CoreGenerators Extract ergo-node specific ConnectedPeerGenerators from CoreGenerators Move DefaultFakePowScheme to ergo-core Dissect ErgoTestConstants into ErgoCoreTestConstants & ErgoNodeTestConstants Move settings.LaunchParameters to ergo-core Dissect ErgoTransactionGenerators into ErgoCoreTransactionGenerators & ErgoNodeTransactionGenerators Dissect part of VotingSpecification to ErgoNodeVotingSpecification
fix test 'valid application of correct extension' fix test 'validation of field value sizes' provide alternate test-generators
Add ergo-core testing and publishing snapshot on PR branch push Fix ergo-core multiversion tests
Closed
kushti
requested changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #2137
Demonstration of how simple it is to create PRs with a clean history.
This would replace: