Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add do-release bash script #2085

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Add do-release bash script #2085

merged 2 commits into from
Dec 22, 2023

Conversation

ross-weir
Copy link
Contributor

closes #2083

ccellado
ccellado reviewed Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@ccellado ccellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script is working, but it checks sequentially
So if there is an error in openapi.yaml and in application.conf it will print only the latter error
Since the script it intended to inform, I think it should check and print all errors regardless

@kushti
Copy link
Member

kushti commented Dec 22, 2023

I think printing one error just is ok in this scenario

@kushti kushti changed the base branch from master to v5.0.18 December 22, 2023 09:42
@kushti kushti merged commit ae6e442 into ergoplatform:v5.0.18 Dec 22, 2023
4 checks passed
@kushti kushti mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccellado ccellado ccellado left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release script
3 participants
@ross-weir @kushti @ccellado