Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added methods to get private key from P2PK address #1978

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Added methods to get private key from P2PK address #1978

merged 2 commits into from
Apr 18, 2023

Conversation

jellymlg
Copy link
Collaborator

Added methods to derive private key for known P2PK addresses.

closes #1976

@jellymlg jellymlg requested a review from kushti April 14, 2023 23:49
@kushti kushti changed the base branch from master to v5.0.10 April 17, 2023 16:48
@kushti kushti changed the base branch from v5.0.10 to master April 17, 2023 16:49
kushti
kushti requested changes Apr 17, 2023
View reviewed changes
Copy link
Member

@kushti kushti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also do a test that getPrivateKeyFromPath is indeed producing secret key corresponding to pubkey (e.g. got via deriveChildPublicKey ) for the same path . Better to add another test with a test vector

src/main/scala/org/ergoplatform/http/api/WalletApiRoute.scala Outdated Show resolved Hide resolved
src/main/scala/org/ergoplatform/nodeView/wallet/ErgoWalletService.scala Outdated Show resolved Hide resolved
@kushti kushti changed the base branch from master to v5.0.10 April 18, 2023 12:37
@kushti kushti merged commit 85a34a6 into v5.0.10 Apr 18, 2023
@kushti kushti deleted the i1976 branch April 18, 2023 12:39
@kushti kushti mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushti kushti kushti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a method to dump private key similar to Bitcoin Core's dumpprivkey
2 participants
@jellymlg @kushti