i1824 guava cache wraps OOM error which is then considered NonFatal and leads to validation error #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragmaxim
changed the title
…vent-oom-from-invalidating-blocks
kushti
requested changes
Sep 2, 2022
| .build[String, BlockSection] | ||
| private val blockSectionsCache = | ||
| Caffeine.newBuilder() | ||
| .maximumSize(config.history.headersCacheSize) |
There was a problem hiding this comment.
why headersCacheSize here ? Looks like a mistake.
There was a problem hiding this comment.
Uff, I misread the lines
| .build[ByteArrayWrapper, Array[Byte]] | ||
| private val indexCache = | ||
| Caffeine.newBuilder() | ||
| .maximumSize(config.history.headersCacheSize) |
kushti
approved these changes
Sep 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1824
The problem is that Guava cache
org.ergoplatform.nodeView.history.storage.HistoryStorage#headersCacheand friends wrap OOM Error into uncheckedExecutionErrorlike thiscom.google.common.util.concurrent.ExecutionError: java.lang.OutOfMemoryError: Java heap spaceand it is then consideredNonFatal=> if it happens during modifier processing it can trigger Validation Error and modifiers get invalidated 🤦