Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show public API URL from other peers if own is off #1821

Merged
merged 8 commits into from
Sep 21, 2022
Merged

Show public API URL from other peers if own is off #1821

merged 8 commits into from
Sep 21, 2022

Conversation

kushti
Copy link
Member

@kushti kushti commented Aug 28, 2022 •
edited
Loading

In this PR:

  • feature serializers moved in one place
  • peer features related abstractions simplified
  • now all the feature serializers used, dependless settings (in particular it fixes an issue when public API URL was not parsed if the node is not announcing own public API URL)

Base automatically changed from v4.0.42 to master September 1, 2022 20:09
@kushti kushti changed the base branch from master to v4.0.46 September 20, 2022 11:47
MrStahlfelge
MrStahlfelge approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@MrStahlfelge MrStahlfelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushti kushti merged commit 6924cdf into v4.0.46 Sep 21, 2022
@kushti kushti deleted the publicurl-fix branch September 21, 2022 17:48
@kushti kushti mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrStahlfelge MrStahlfelge MrStahlfelge approved these changes

@pragmaxim pragmaxim pragmaxim approved these changes

@greenhat greenhat greenhat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kushti @greenhat @pragmaxim @MrStahlfelge