avoid using global LaunchParameters throughout the codebase #1563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of Randomness in tests which causes non-deterministic failures, especially with generators that run a test many times. When we have complete control over
parameters
then we can change it or override it on a single place and troubleshoot all tests together, ie. avoid fixing one and breaking others.With this change,
parameters
are propagated as an instance wherever it is needed, instead of just callingLaunchParameters
global object from everywhere.I tried to change the randomly generated numbers that are used to generate boxes, transactions and blocks, but after day of trying, not being able to make ALL test pass with it, I figured the only way is to increase some limits like
maxBlockCost
orminValuePerByte
just on a two places.