P2P networking support for bootstrapping with UTXO set snapshot #1444
Conversation
…-set-bootstrapping
kushti
changed the title
kushti
changed the title
…otDownloadPlan, scaladocs
kushti
requested review from
pragmaxim,
aslesarenko,
ccellado,
ApexTheory and
jellymlg
| @@ -13,8 +12,8 @@ class ManifestSerializer(manifestDepth: Byte) extends ErgoSerializer[BatchAVLPro | |||
| private val nodeSerializer = VersionedLDBAVLStorage.noStoreSerializer | |||
|
|
|||
| override def serialize(manifest: BatchAVLProverManifest[DigestType], w: Writer): Unit = { | |||
| val height = manifest.rootHeight | |||
| w.putBytes(Ints.toByteArray(height)) | |||
| val rootNodeHeight = manifest.rootHeight.toByte | |||
There was a problem hiding this comment.
Shouldn't it be toByteExact?
There was a problem hiding this comment.
No, by construction AVL+ tree has height <= 127 , then manifest has the same limitation also. Need to fix manifest in scrypto about that
There was a problem hiding this comment.
Yes, but it makes more assumption about input data. If however there is a mistake in the data, the silent overflow will lead to hard to localize bugs. Why not to do checks here? It will not impact performance.
There was a problem hiding this comment.
There MUST BE NOT mistakes here, if prover is having root height > 127 it can not work with the tree simply, forming bad manifest is very secondary issue then. Even more, height is much less than 127 always, there is a descriptive comment in scrypto about that.
There was a problem hiding this comment.
ok, I just curious why you think not checking overflow is better than checking?
There was a problem hiding this comment.
Because it could be more confusing actually for a reader to find a check for a thing which MUST NOT happen by construction. Conversion to int in some manifest / db classes is already confusing.
avldb/src/main/scala/scorex/crypto/authds/avltree/batch/VersionedLDBAVLStorage.scala
Show resolved
Hide resolved
src/main/scala/org/ergoplatform/network/ErgoNodeViewSynchronizer.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/ergoplatform/settings/NodeConfigurationSettings.scala
Show resolved
Hide resolved
src/main/scala/org/ergoplatform/settings/NodeConfigurationSettings.scala
Show resolved
Hide resolved
Eliminate insert(values: Array[(K, V)]) in LDBKVStore
… into utxo-set-bootstrapping
|
@aslesarenko added manifest verification also in f4b2654 |
This PR implements P2P networking protocol for bootstrapping with UTXO set snapshot. The final big chunk of the code related to the new functionality.