Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unite ConnectedPeer.peerInfo and PeerInfo.lastStoredActivityTime #1959

Closed
kushti opened this issue Feb 26, 2023 · 0 comments · Fixed by #2035
Closed

Unite ConnectedPeer.peerInfo and PeerInfo.lastStoredActivityTime #1959

kushti opened this issue Feb 26, 2023 · 0 comments · Fixed by #2035
Assignees
@ccellado
Labels
B-200 SigUSD

Comments

@kushti
Copy link
Member

kushti commented Feb 26, 2023

Currently, ConnectedPeer.peerInfo and PeerInfo.lastStoredActivityTime storing the same information, and with activityDelta in NetworkController being set to 1 minute, the former can be eliminated.
@ccellado ccellado self-assigned this Feb 27, 2023
ccellado added a commit to ccellado/ergo that referenced this issue Sep 12, 2023
@ccellado
ergoplatform#1959 Remove lastActivity from ConnectedPeer
1f23bd6
@ccellado ccellado mentioned this issue Sep 12, 2023
Merged
kushti added a commit that referenced this issue Sep 18, 2023
@kushti
Merge pull request #2035 from ccellado/unite_time_delta_info
125a469 
#1959 Remove lastStoredActivityTime from ConnectedPeer
@kushti kushti closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccellado ccellado

Labels
B-200 SigUSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1959 Remove lastStoredActivityTime from ConnectedPeer ccellado/ergo
2 participants
@kushti @ccellado