You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder why SnapshotsDb.readSubtreeBytes and SnapshotsDb.readManifestBytes methods are called read*Bytes while them are actually returning deserialized BatchAVLProverManifest and BatchAVLProverSubtree?
Should I serialize them in array of bytes?
And is there any sense in serializing data fetched from the database to immediately serialize it back to send through network?
I wonder why SnapshotsDb.readSubtreeBytes and SnapshotsDb.readManifestBytes methods are called read*Bytes while them are actually returning deserialized BatchAVLProverManifest and BatchAVLProverSubtree? Should I serialize them in array of bytes? And is there any sense in serializing data fetched from the database to immediately serialize it back to send through network?
No sense in serialization round-trip just to send bytes over the wire.
Thus I think it is better to have SnapshotsDb.readSubtreeBytes / SnapshotsDb.readManifestBytes methods (reading bytes) along with SnapshotsDb.readSubtree / SnapshotsDb.readManifest (reading entities) , and use former for p2p messaging
Implement following new messages on top of #1514
The text was updated successfully, but these errors were encountered: