Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix truncation check #2170

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix truncation check #2170

merged 2 commits into from
Jun 11, 2024

Conversation

slingamn
Copy link
Member

  • The message target was not being counted :-(
  • The additional character added to the target by STATUSMSG was not counted

This will break irctest, but the irctest is actually wrong: progval/irctest#281

@slingamn
fix truncation check
0b333c7 
* The message target was not being counted :-(
* The additional character added to the target by STATUSMSG was not counted
@slingamn
bump irctest to fork's master
2bb0a9c
@slingamn slingamn merged commit 9b8562c into ergochat:master Jun 11, 2024
@slingamn
Copy link
Member Author

This is not a security issue because ircmsg will always fall back to truncating to <=512 bytes of valid UTF8, it's just an issue with the correctness of allow-truncation: false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slingamn