Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to handle accounts.email-verification.blacklist-regexes? #1997

Closed
ghost opened this issue Sep 9, 2022 · 2 comments
Closed

Better way to handle accounts.email-verification.blacklist-regexes? #1997

ghost opened this issue Sep 9, 2022 · 2 comments
Milestone

Comments

@ghost
Copy link

ghost commented Sep 9, 2022

Sorry for the poor title, please adjust as needed.


Would be nice to be able to read a list of emails to block from a file, or something. If you want to keep something like disposable_email_blocklist.conf in your ergo.yaml, you end up with literally 1000s of lines and it's a pain to keep up-to-date.

Aside: the example of regexs should actually be like: .*@example\\.com

@slingamn
Copy link
Member

Good suggestion! I'll take a look at this for the next release.

@slingamn slingamn added this to the v2.11 milestone Sep 18, 2022
@slingamn slingamn modified the milestones: v2.11, selected Dec 11, 2022
@slingamn slingamn modified the milestones: selected, v2.12.0 Jul 30, 2023
@slingamn
Copy link
Member

@progval noted that YAML includes would be ideal for this, however AIUI neither v2 nor v3 of our YAML library supports them. Switching to another library is risky in terms of compatibility breaks.

slingamn added a commit to slingamn/ergo that referenced this issue Sep 11, 2023
Provide blacklist-regex-file for a more easily rewritten / reloaded
list of blacklisted email addresses.

Also make regexes case-insensitive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant