Gracefully handle NS cert add myself <fp> (#2128)

* Gracefully handle NS cert add myself <fp> A non-operator with the nick "mynick" attempts to register a fingerprint to their authenticated account. They /msg NickServ cert add mynick <fingerprint> NickServ responds with "Insufficient privileges" because they've accidentally invoked the operator syntax (to action other accounts). This patch allows the user to add the fingerprint if the client's account is identical to the target account. Signed-off-by: Matt Hamilton <[email protected]> * Update nickserv.go Compare the case-normalized target to Account() --------- Signed-off-by: Matt Hamilton <[email protected]> Co-authored-by: Shivaram Lingamneni <[email protected]>
ergochat · Feb 14, 2024 · c67835c · c67835c
1 parent 7afd6db
commit c67835c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/irc/nickserv.go b/irc/nickserv.go
@@ -1398,6 +1398,11 @@ func nsCertHandler(service *ircService, server *Server, client *Client, command
 	case "add", "del":
 		if 2 <= len(params) {
 			target, certfp = params[0], params[1]
+			if cftarget, err := CasefoldName(target); err == nil && client.Account() == cftarget {
+				// If the target is equal to the account, then the user accidentally invoked operator
+				// syntax (cert add mynick <fp>) instead of self syntax (cert add <fp>).
+				target = ""
+			}
 		} else if len(params) == 1 {
 			certfp = params[0]
 		} else if len(params) == 0 && verb == "add" && rb.session.certfp != "" {