Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

Commit

Permalink
Merge pull request #435 from ergebnis/fix/method
Browse files Browse the repository at this point in the history
Fix: Use magic methods instead of magic properties
  • Loading branch information
ergebnis-bot authored Mar 30, 2021
2 parents 4a77eb6 + 4d6ee9c commit 7c85925
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ For a full diff see [`1.4.0...1.5.0`][1.4.0...1.5.0].

* Updated `fakerphp/faker` ([#434]), by [@dependabot]

### Fixed

* Stopped using deprecated magic properties on `Faker\Generator` and started using magic functions instead ([#435]), by [@localheinz]

## [`1.4.0`][1.4.0]

For a full diff see [`1.3.0...1.4.0`][1.3.1...1.4.0].
Expand Down Expand Up @@ -178,6 +182,7 @@ For a full diff see [`0.7.0...0.8.0`][0.7.0...0.8.0].
[#372]: https://github.com/ergebnis/test-util/pull/372
[#374]: https://github.com/ergebnis/test-util/pull/374
[#434]: https://github.com/ergebnis/test-util/pull/434
[#435]: https://github.com/ergebnis/test-util/pull/435

[@dependabot]: https://github.com/dependabot
[@ergebnis]: https://github.com/ergebnis
Expand Down
6 changes: 3 additions & 3 deletions src/DataProvider/StringProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ private static function values(): array
$faker = self::faker();

$arbitraryValues = [
'string-arbitrary-sentence' => $faker->sentence,
'string-arbitrary-word' => $faker->word,
'string-arbitrary-sentence' => $faker->sentence(),
'string-arbitrary-word' => $faker->word(),
];

$whitespaceCharacters = self::whitespaceCharacters();
Expand Down Expand Up @@ -125,7 +125,7 @@ private static function values(): array
$whitespaceCharacter,
$faker->numberBetween(1, 5)
),
$faker->word,
$faker->word(),
\str_repeat(
$whitespaceCharacter,
$faker->numberBetween(1, 5)
Expand Down

0 comments on commit 7c85925

Please sign in to comment.