Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for nullable union types #543

Merged
merged 1 commit into from
May 1, 2023

Conversation

localheinz
Copy link
Member

This pull request

  • adds support for nullable union types

Fixes #472.

@localheinz localheinz self-assigned this May 1, 2023
@localheinz localheinz requested a review from ergebnis-bot as a code owner May 1, 2023 17:45
@localheinz localheinz force-pushed the feature/union-type branch from c608dd6 to a30df11 Compare May 1, 2023 17:48
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #543 (a30df11) into main (cdb4290) will increase coverage by 0.66%.
The diff coverage is 91.66%.

❗ Current head a30df11 differs from pull request most recent head eb91113. Consider uploading reports for the commit eb91113 to get more accurate results

@@             Coverage Diff              @@
##               main     #543      +/-   ##
============================================
+ Coverage     83.88%   84.54%   +0.66%     
- Complexity      154      190      +36     
============================================
  Files            22       22              
  Lines           608      673      +65     
============================================
+ Hits            510      569      +59     
- Misses           98      104       +6     
Impacted Files Coverage Δ
...c/Closures/NoNullableReturnTypeDeclarationRule.php 76.00% <91.66%> (+11.71%) ⬆️
...res/NoParameterWithNullableTypeDeclarationRule.php 82.85% <91.66%> (+3.69%) ⬆️
.../Functions/NoNullableReturnTypeDeclarationRule.php 76.66% <91.66%> (+8.24%) ⬆️
...ons/NoParameterWithNullableTypeDeclarationRule.php 83.78% <91.66%> (+3.01%) ⬆️
...rc/Methods/NoNullableReturnTypeDeclarationRule.php 83.78% <91.66%> (+2.30%) ⬆️
...ods/NoParameterWithNullableTypeDeclarationRule.php 88.00% <91.66%> (+0.82%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz force-pushed the feature/union-type branch from a30df11 to eb91113 Compare May 1, 2023 17:54
@localheinz localheinz merged commit ebe06fa into main May 1, 2023
@localheinz localheinz deleted the feature/union-type branch May 1, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullable return type declaration with explicit types
2 participants