Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods\FinalInAbstractClassRule: allow __construct method to be non-final #248

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented Jul 29, 2020

This PR

  • Allow public __construct to be non-final, as the template method pattern is a behavioural pattern and not a creational one

Related to #88, #123

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #248 into main will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #248      +/-   ##
============================================
+ Coverage     83.88%   83.95%   +0.06%     
- Complexity      149      150       +1     
============================================
  Files            23       23              
  Lines           484      486       +2     
============================================
+ Hits            406      408       +2     
  Misses           78       78              
Impacted Files Coverage Δ Complexity Δ
src/Methods/FinalInAbstractClassRule.php 80.00% <100.00%> (+1.73%) 9.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51e259...ea6621d. Read the comment docs.

@Slamdunk
Copy link
Contributor Author

@localheinz OT question: do you as "localheinz" get notified on a new PR such this is opened against "ergebnis" organization?

@localheinz
Copy link
Member

@Slamdunk

I do! Will take a look later!

@localheinz localheinz self-requested a review July 31, 2020 17:22
@localheinz localheinz self-assigned this Jul 31, 2020
@localheinz localheinz force-pushed the final_abstract_allow_constructor branch from 5b5d5ac to ea6621d Compare July 31, 2020 17:55
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit db1d46b into ergebnis:main Jul 31, 2020
@localheinz
Copy link
Member

Thank you, @Slamdunk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants