Merge pull request #392 from ergebnis/fix/split

Fix: Split condition
ergebnis · Nov 8, 2021 · 998cd88 · 998cd88
2 parents d86a1d5 + fdc53d8
commit 998cd88
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/integrate.yaml b/.github/workflows/integrate.yaml
@@ -10,7 +10,7 @@ on: # yamllint disable-line rule:truthy
 
 env:
   MIN_COVERED_MSI: 92
-  MIN_MSI: 83
+  MIN_MSI: 82
   PHP_EXTENSIONS: "mbstring"
 
 jobs:

diff --git a/Makefile b/Makefile
@@ -1,5 +1,5 @@
 MIN_COVERED_MSI:=92
-MIN_MSI:=83
+MIN_MSI:=82
 
 .PHONY: it
 it: coding-standards static-code-analysis tests ## Runs the coding-standards, static-code-analysis, and tests targets

diff --git a/src/Functions/NoNullableReturnTypeDeclarationRule.php b/src/Functions/NoNullableReturnTypeDeclarationRule.php
@@ -37,7 +37,11 @@ public function processNode(
             ));
         }
 
-        if (!isset($node->namespacedName) || !$node->getReturnType() instanceof Node\NullableType) {
+        if (!isset($node->namespacedName)) {
+            return [];
+        }
+
+        if (!$node->getReturnType() instanceof Node\NullableType) {
             return [];
         }