Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use commit hash to calculate cache key #135

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix: Use commit hash to calculate cache key #135

merged 1 commit into from
Nov 7, 2019

Conversation

localheinz
Copy link
Member

This PR

  • uses the commit hash to calculate cache key

💁‍♂ For reference, see actions/cache#65.

Looks like you're right, @bendavies, this indeed works better.

@localheinz localheinz added the bug label Nov 7, 2019
@localheinz localheinz self-assigned this Nov 7, 2019
@localheinz localheinz merged commit 10d2816 into master Nov 7, 2019
@localheinz localheinz deleted the fix/sha branch November 7, 2019 07:30
@bendavies
Copy link
Contributor

I honestly think this is bug in action/cache. this shouldn't be a warning.
if you have a composer.lock committed, it's perfectly find to has on it.

@localheinz localheinz mentioned this pull request Nov 8, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@localheinz localheinz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @bendavies