EnhancementL Use JSON_THROW_ON_ERROR flag

ergebnis · Nov 28, 2022 · 8b948d4 · 8b948d4
1 parent addc246
commit 8b948d4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,2 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="4.6.4@97fe86c4e158b5a57c5150aa5055c38b5a809aab"/>
+<files psalm-version="4.30.0@d0bc6e25d89f649e4f36a534f330f8bb4643dd69">
+  <file src="src/Printer.php">
+    <UnusedFunctionCall occurrences="1">
+      <code>\json_decode</code>
+    </UnusedFunctionCall>
+  </file>
+</files>
diff --git a/src/Printer.php b/src/Printer.php
@@ -38,7 +38,14 @@ final class Printer implements PrinterInterface
      */
     public function print(string $json, string $indent = '    ', string $newLine = \PHP_EOL): string
     {
-        if (null === \json_decode($json) && \JSON_ERROR_NONE !== \json_last_error()) {
+        try {
+            \json_decode(
+                $json,
+                false,
+                512,
+                \JSON_THROW_ON_ERROR,
+            );
+        } catch (\JsonException $exception) {
             throw new \InvalidArgumentException(\sprintf(
                 '"%s" is not valid JSON.',
                 $json,