Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #993

Merged

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Oct 11, 2023

This pull request contains some of the code from #981, as suggested in #981 (comment). The changes here do not achieve a score of 100% from the mutation testing, but it is 7 percentage points higher than the minimum required, and does not increase the time it takes to run the mutation tests.

Each of the changes here were inspired by "escaped mutants" as reported by infection/infection when configured to not skip half of the tests.

Related to #981

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #993 (a5a835f) into main (773c0ac) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #993      +/-   ##
============================================
+ Coverage     97.77%   98.03%   +0.26%     
- Complexity      177      179       +2     
============================================
  Files            30       30              
  Lines           763      763              
============================================
+ Hits            746      748       +2     
+ Misses           17       15       -2     
Files Coverage Δ
src/Format/JsonEncodeOptions.php 100.00% <100.00%> (ø)
src/Format/NewLine.php 100.00% <100.00%> (ø)
src/Vendor/Composer/PackageHashNormalizer.php 97.95% <100.00%> (ø)
...rc/Vendor/Composer/VersionConstraintNormalizer.php 99.38% <100.00%> (+0.61%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz self-assigned this Dec 6, 2023
@localheinz localheinz merged commit 93537bc into ergebnis:main Dec 6, 2023
19 checks passed
@localheinz
Copy link
Member

Thank you, @fredden!

@fredden fredden deleted the test-coverage-no-mutation-changes branch December 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants