Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #867: Fixing variable type error by casting the value. #868

Merged

Conversation

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #868 (f0e2288) into main (32e5178) will not change coverage.
The diff coverage is 100.00%.

❗ Current head f0e2288 differs from pull request most recent head fb6e3da. Consider uploading reports for the commit fb6e3da to get more accurate results

@@            Coverage Diff            @@
##               main     #868   +/-   ##
=========================================
  Coverage     97.49%   97.49%           
  Complexity      158      158           
=========================================
  Files            30       30           
  Lines           679      679           
=========================================
  Hits            662      662           
  Misses           17       17           
Impacted Files Coverage Δ
src/SchemaNormalizer.php 96.20% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fredden
Copy link
Contributor

fredden commented Mar 9, 2023

@localheinz from what I can tell, this fixes the bug. I don't know how to make the psalm error go away though.

@localheinz localheinz force-pushed the 867--fix-cast-variable-type branch from 8c02540 to 4bca3c1 Compare May 2, 2023 08:16
@localheinz localheinz merged commit 1dbc600 into ergebnis:main May 2, 2023
@localheinz
Copy link
Member

Thank you, @alexis-saransig-lullabot and @fredden!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants