Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Skip normalization of unparseable version constraints #813

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Jan 5, 2023

This pull request

  • requires composer/semver
  • suggests composer/semver
  • uses composer/semver to avoid attempting to normalize unparseable version constraints

Related to #756.

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #813 (d4f2128) into main (af6383b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d4f2128 differs from pull request most recent head 0661133. Consider uploading reports for the commit 0661133 to get more accurate results

@@             Coverage Diff              @@
##               main     #813      +/-   ##
============================================
+ Coverage     98.27%   98.28%   +0.01%     
- Complexity      131      133       +2     
============================================
  Files            27       27              
  Lines           405      409       +4     
============================================
+ Hits            398      402       +4     
  Misses            7        7              
Impacted Files Coverage Δ
src/Vendor/Composer/ComposerJsonNormalizer.php 100.00% <100.00%> (ø)
...rc/Vendor/Composer/VersionConstraintNormalizer.php 96.42% <100.00%> (+0.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz marked this pull request as ready for review January 5, 2023 21:05
@localheinz localheinz changed the title Enhancement: Require, suggest, and use composer/semver Enhancement: Skip normalization of unparseable version constraints Jan 5, 2023
@localheinz localheinz merged commit 113e8e6 into main Jan 5, 2023
@localheinz localheinz deleted the feature/semver branch January 5, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants