Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sniff only pure indents, no mixed spaces and tabs #71

Merged
merged 2 commits into from
Aug 12, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Aug 12, 2018

This PR

  • asserts that sniffed indents are pure (that is, either space or tab, but not mixed)
  • adjusts a regular expression

Related to #69.

@localheinz localheinz added the bug label Aug 12, 2018
@localheinz localheinz self-assigned this Aug 12, 2018
@localheinz localheinz changed the title Fix: Sniff only pure indents Fix: Sniff only pure indents, no mixed spaces and tabs Aug 12, 2018
@localheinz localheinz force-pushed the fix/indent branch 6 times, most recently from f970144 to 724a061 Compare August 12, 2018 17:51
@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #71   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      108    108           
=======================================
  Files            13     13           
  Lines           314    314           
=======================================
  Hits            314    314
Impacted Files Coverage Δ Complexity Δ
src/Format/Sniffer.php 100% <100%> (ø) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ccc17...e6e7e18. Read the comment docs.

@localheinz localheinz merged commit e6a2c7b into master Aug 12, 2018
@localheinz localheinz deleted the fix/indent branch August 12, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant