Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Actually rtrim() JSON in FinalNewLineNormalizer #5

Merged
merged 2 commits into from
Jan 12, 2018

Conversation

localheinz
Copy link
Member

This PR

  • actually appends whitespace to $json before passing it to the FinalNewLineNormalizer in a test
  • actually rtrim() $json before appending PHP_EOL in the FinalNewLineNormalizer

Follows #2.

@localheinz localheinz added the bug label Jan 12, 2018
@localheinz localheinz self-assigned this Jan 12, 2018
@localheinz localheinz force-pushed the fix/final-new-line-normalizer branch from b44de6a to 0a2013f Compare January 12, 2018 14:46
@codecov
Copy link

codecov bot commented Jan 12, 2018

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #5   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       12     12           
=======================================
  Files             3      3           
  Lines            27     27           
=======================================
  Hits             27     27
Impacted Files Coverage Δ Complexity Δ
src/FinalNewLineNormalizer.php 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f27f45...ca520ce. Read the comment docs.

@localheinz localheinz changed the title Fix: Actually rtrim JSON in FinalNewLineNormalizer Fix: Actually rtrim() JSON in FinalNewLineNormalizer Jan 12, 2018
@localheinz localheinz merged commit 021e387 into master Jan 12, 2018
@localheinz localheinz deleted the fix/final-new-line-normalizer branch January 12, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant