Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not sort preferred-install hash #425

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 30, 2020

This PR

  • asserts that the preferred-install hash is not sorted by key
  • stops sorting the preferred-install hash

Related to ergebnis/composer-normalize#644.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #425 (e5e4efb) into main (f318c64) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main      #425   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       163       164    +1     
===========================================
  Files             34        34           
  Lines            505       512    +7     
===========================================
+ Hits             505       512    +7     
Impacted Files Coverage Δ Complexity Δ
src/Vendor/Composer/ConfigHashNormalizer.php 100.00% <100.00%> (ø) 8.00 <4.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f318c64...e5e4efb. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Dec 30, 2020
@ergebnis-bot ergebnis-bot merged commit fe3aea2 into main Dec 30, 2020
@ergebnis-bot ergebnis-bot deleted the fix/preferred-install branch December 30, 2020 15:11
*
* @var array<int, string>
*/
private static $propertiesThatShouldNotBeSorted = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use a const for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants