Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace x and X wildcards with * #1052

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Dec 31, 2023

This pull request was inspired by https://twitter.com/localheinz/status/1741201630681272557. While I expect a major change to the test-suite here with the incorporation of new packages in the "ergebnis" namespace, normalising x and X to * seems like a sensible addition to composer-normalize.

  • Replace x and X wildcards with *
  • Reduce some duplicate code with the introduction of a new private method

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3582368) 96.44% compared to head (41c6799) 96.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1052      +/-   ##
============================================
+ Coverage     96.44%   96.46%   +0.02%     
  Complexity      196      196              
============================================
  Files            32       32              
  Lines           759      764       +5     
============================================
+ Hits            732      737       +5     
  Misses           27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredden

This comment was marked as outdated.

@localheinz localheinz self-assigned this Jan 7, 2024
@localheinz localheinz force-pushed the death-star-version-constraint-xX branch from 44a5e7b to 227bf02 Compare February 17, 2024 12:33
@localheinz localheinz merged commit a223192 into ergebnis:main Feb 17, 2024
24 checks passed
@localheinz
Copy link
Member

Thank you, @fredden!

@fredden fredden deleted the death-star-version-constraint-xX branch February 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants