Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading v prefixes from version strings #1027

Merged

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Dec 4, 2023

This pull request

  • removes leading v characters from version numbers

Fixes #1003

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (604a8b9) 98.03% compared to head (b61cd4a) 98.07%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1027      +/-   ##
============================================
+ Coverage     98.03%   98.07%   +0.04%     
- Complexity      179      181       +2     
============================================
  Files            30       30              
  Lines           763      779      +16     
============================================
+ Hits            748      764      +16     
  Misses           15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz force-pushed the remove-leading-v-from-version-strings branch 4 times, most recently from 293eb97 to b46dab0 Compare December 13, 2023 09:00
@localheinz localheinz changed the title Remove leading 'v' character from version strings Remove leading v prefixes from version strings Dec 13, 2023
@localheinz localheinz force-pushed the remove-leading-v-from-version-strings branch from b46dab0 to b61cd4a Compare December 13, 2023 09:03
@localheinz localheinz merged commit 7136b06 into ergebnis:main Dec 13, 2023
19 checks passed
@localheinz
Copy link
Member

Thank you, @fredden!

@fredden fredden deleted the remove-leading-v-from-version-strings branch December 13, 2023 11:11
@sstok
Copy link

sstok commented Dec 17, 2023

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong ordering for minor version constraints in composer file
3 participants