Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort repository filtering lists (only, exclude) #1001

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Oct 27, 2023

This pull request builds on the work done in #980 where we are now able to reliably sort lists of packages when wildcards are allowed.

This pull request

  • Sorts the only and exclude lists of packages within each repository entry (ie, those under the repositories key) in composer.json.
  • Leaves the lists as-is when wildcards are detected other than at the end of strings.

Follows #980

See also https://getcomposer.org/doc/articles/repository-priorities.md#filtering-packages

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (fe9f378) 98.07% compared to head (47cc067) 91.59%.

❗ Current head 47cc067 differs from pull request most recent head 022bbd7. Consider uploading reports for the commit 022bbd7 to get more accurate results

Files Patch % Lines
src/Vendor/Composer/WildcardSorter.php 0.00% 25 Missing ⚠️
src/Vendor/Composer/RepositoriesHashNormalizer.php 40.74% 16 Missing ⚠️
src/Vendor/Composer/ConfigHashNormalizer.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1001      +/-   ##
============================================
- Coverage     98.07%   91.59%   -6.48%     
- Complexity      181      194      +13     
============================================
  Files            30       32       +2     
  Lines           779      809      +30     
============================================
- Hits            764      741      -23     
- Misses           15       68      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz self-assigned this Dec 6, 2023
@localheinz localheinz force-pushed the sort/repository-filtering branch 5 times, most recently from 8391901 to 2ad6097 Compare December 13, 2023 09:15
@localheinz localheinz force-pushed the sort/repository-filtering branch 2 times, most recently from 2c95456 to 47cc067 Compare December 13, 2023 09:29
@localheinz localheinz force-pushed the sort/repository-filtering branch from 47cc067 to 022bbd7 Compare December 13, 2023 09:30
@localheinz localheinz merged commit eba9b55 into ergebnis:main Dec 13, 2023
17 checks passed
@localheinz
Copy link
Member

Thank you, @fredden!

@fredden fredden deleted the sort/repository-filtering branch December 13, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants