Merge pull request #4 from localheinz/feature/abstract-normalizer-tes…

…t-case Enhancement: Extract AbstractNormalizerTestCase
ergebnis · Jan 12, 2018 · 8749041 · 8749041
2 parents 1f27f45 + 09c3177
commit 8749041
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 83 deletions.
diff --git a/test/Unit/AbstractNormalizerTestCase.php b/test/Unit/AbstractNormalizerTestCase.php
@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2018 Andreas Möller.
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ *
+ * @see https://github.com/localheinz/json-normalizer
+ */
+
+namespace Localheinz\Json\Normalizer\Test\Unit;
+
+use Localheinz\Json\Normalizer\NormalizerInterface;
+use Localheinz\Test\Util\Helper;
+use PHPUnit\Framework;
+
+abstract class AbstractNormalizerTestCase extends Framework\TestCase
+{
+    use Helper;
+
+    final public function testImplementsNormalizerInterface()
+    {
+        $this->assertClassImplementsInterface(NormalizerInterface::class, $this->className());
+    }
+
+    final public function testNormalizeRejectsInvalidJson()
+    {
+        $json = $this->faker()->realText();
+
+        $reflection = new \ReflectionClass($this->className());
+
+        $normalizer = $reflection->newInstanceWithoutConstructor();
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage(\sprintf(
+            '"%s" is not valid JSON.',
+            $json
+        ));
+
+        $normalizer->normalize($json);
+    }
+
+    final protected function className(): string
+    {
+        return \preg_replace(
+            '/Test$/',
+            '',
+            \str_replace(
+                'Localheinz\\Json\\Normalizer\\Test\\Unit\\',
+                'Localheinz\\Json\\Normalizer\\',
+                static::class
+            )
+        );
+    }
+}
diff --git a/test/Unit/FinalNewLineNormalizerTest.php b/test/Unit/FinalNewLineNormalizerTest.php
@@ -14,34 +14,9 @@
 namespace Localheinz\Json\Normalizer\Test\Unit;
 
 use Localheinz\Json\Normalizer\FinalNewLineNormalizer;
-use Localheinz\Json\Normalizer\NormalizerInterface;
-use Localheinz\Test\Util\Helper;
-use PHPUnit\Framework;
 
-final class FinalNewLineNormalizerTest extends Framework\TestCase
+final class FinalNewLineNormalizerTest extends AbstractNormalizerTestCase
 {
-    use Helper;
-
-    public function testImplementsNormalizerInterface()
-    {
-        $this->assertClassImplementsInterface(NormalizerInterface::class, FinalNewLineNormalizer::class);
-    }
-
-    public function testNormalizeRejectsInvalidJson()
-    {
-        $json = $this->faker()->realText();
-
-        $normalizer = new FinalNewLineNormalizer();
-
-        $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage(\sprintf(
-            '"%s" is not valid JSON.',
-            $json
-        ));
-
-        $normalizer->normalize($json);
-    }
-
     /**
      * @dataProvider providerWhitespace
      *

diff --git a/test/Unit/IndentNormalizerTest.php b/test/Unit/IndentNormalizerTest.php
@@ -14,21 +14,11 @@
 namespace Localheinz\Json\Normalizer\Test\Unit;
 
 use Localheinz\Json\Normalizer\IndentNormalizer;
-use Localheinz\Json\Normalizer\NormalizerInterface;
 use Localheinz\Json\Printer\PrinterInterface;
-use Localheinz\Test\Util\Helper;
-use PHPUnit\Framework;
 use Prophecy\Argument;
 
-final class IndentNormalizerTest extends Framework\TestCase
+final class IndentNormalizerTest extends AbstractNormalizerTestCase
 {
-    use Helper;
-
-    public function testImplementsNormalizerInterface()
-    {
-        $this->assertClassImplementsInterface(NormalizerInterface::class, IndentNormalizer::class);
-    }
-
     /**
      * @dataProvider providerInvalidIndent
      *
@@ -62,26 +52,6 @@ public function providerInvalidIndent(): \Generator
         }
     }
 
-    public function testNormalizeRejectsInvalidJson()
-    {
-        $indent = '  ';
-
-        $json = $this->faker()->realText();
-
-        $normalizer = new IndentNormalizer(
-            $indent,
-            $this->prophesize(PrinterInterface::class)->reveal()
-        );
-
-        $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage(\sprintf(
-            '"%s" is not valid JSON.',
-            $json
-        ));
-
-        $normalizer->normalize($json);
-    }
-
     public function testNormalizeUsesPrinterToNormalizeJsonWithIndent()
     {
         $indent = '  ';

diff --git a/test/Unit/NoFinalNewLineNormalizerTest.php b/test/Unit/NoFinalNewLineNormalizerTest.php
@@ -14,34 +14,9 @@
 namespace Localheinz\Json\Normalizer\Test\Unit;
 
 use Localheinz\Json\Normalizer\NoFinalNewLineNormalizer;
-use Localheinz\Json\Normalizer\NormalizerInterface;
-use Localheinz\Test\Util\Helper;
-use PHPUnit\Framework;
 
-final class NoFinalNewLineNormalizerTest extends Framework\TestCase
+final class NoFinalNewLineNormalizerTest extends AbstractNormalizerTestCase
 {
-    use Helper;
-
-    public function testImplementsNormalizerInterface()
-    {
-        $this->assertClassImplementsInterface(NormalizerInterface::class, NoFinalNewLineNormalizer::class);
-    }
-
-    public function testNormalizeRejectsInvalidJson()
-    {
-        $json = $this->faker()->realText();
-
-        $normalizer = new NoFinalNewLineNormalizer();
-
-        $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage(\sprintf(
-            '"%s" is not valid JSON.',
-            $json
-        ));
-
-        $normalizer->normalize($json);
-    }
-
     /**
      * @dataProvider providerWhitespace
      *