Merge pull request #266 from ergebnis/fix/default

Fix: Initialize fields with default values
ergebnis · Apr 19, 2020 · 1ddecc1 · 1ddecc1
2 parents b556041 + 98c2ee3
commit 1ddecc1
Show file tree

Hide file tree

Showing 25 changed files with 101 additions and 79 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="3.10.1@eeed5ecccc10131397f0eb7ee6da810c0be3a7fc">
+<files psalm-version="3.11.2@d470903722cfcbc1cd04744c5491d3e6d13ec3d9">
   <file src="src/CallableNormalizer.php">
     <MixedInferredReturnType occurrences="1">
       <code>Json</code>
@@ -8,66 +8,6 @@
       <code>$callable($json)</code>
     </MixedReturnStatement>
   </file>
-  <file src="src/Exception/InvalidIndentSizeException.php">
-    <MissingConstructor occurrences="1">
-      <code>$size</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/InvalidIndentStringException.php">
-    <MissingConstructor occurrences="1">
-      <code>$string</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/InvalidIndentStyleException.php">
-    <MissingConstructor occurrences="1">
-      <code>$style</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/InvalidJsonEncodeOptionsException.php">
-    <MissingConstructor occurrences="1">
-      <code>$jsonEncodeOptions</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/InvalidJsonEncodedException.php">
-    <MissingConstructor occurrences="1">
-      <code>$encoded</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/InvalidNewLineStringException.php">
-    <MissingConstructor occurrences="1">
-      <code>$string</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/NormalizedInvalidAccordingToSchemaException.php">
-    <MissingConstructor occurrences="1">
-      <code>$schemaUri</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/OriginalInvalidAccordingToSchemaException.php">
-    <MissingConstructor occurrences="1">
-      <code>$schemaUri</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/SchemaUriCouldNotBeReadException.php">
-    <MissingConstructor occurrences="1">
-      <code>$schemaUri</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/SchemaUriCouldNotBeResolvedException.php">
-    <MissingConstructor occurrences="1">
-      <code>$schemaUri</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/SchemaUriReferencesDocumentWithInvalidMediaTypeException.php">
-    <MissingConstructor occurrences="1">
-      <code>$schemaUri</code>
-    </MissingConstructor>
-  </file>
-  <file src="src/Exception/SchemaUriReferencesInvalidJsonDocumentException.php">
-    <MissingConstructor occurrences="1">
-      <code>$schemaUri</code>
-    </MissingConstructor>
-  </file>
   <file src="src/Json.php">
     <DocblockTypeContradiction occurrences="1">
       <code>null === $this-&gt;format</code>
@@ -120,10 +60,6 @@
     </MixedAssignment>
   </file>
   <file src="src/Vendor/Composer/PackageHashNormalizer.php">
-    <MixedArgumentTypeCoercion occurrences="2">
-      <code>$packages</code>
-      <code>$packages</code>
-    </MixedArgumentTypeCoercion>
     <MixedAssignment occurrences="1">
       <code>$value</code>
     </MixedAssignment>

diff --git a/src/Exception/InvalidIndentSizeException.php b/src/Exception/InvalidIndentSizeException.php
@@ -18,12 +18,12 @@ final class InvalidIndentSizeException extends \InvalidArgumentException impleme
     /**
      * @var int
      */
-    private $size;
+    private $size = 0;
 
     /**
      * @var int
      */
-    private $minimumSize;
+    private $minimumSize = 0;
 
     public static function fromSizeAndMinimumSize(int $size, int $minimumSize): self
     {

diff --git a/src/Exception/InvalidIndentStringException.php b/src/Exception/InvalidIndentStringException.php
@@ -18,7 +18,7 @@ final class InvalidIndentStringException extends \InvalidArgumentException imple
     /**
      * @var string
      */
-    private $string;
+    private $string = '';
 
     public static function fromString(string $string): self
     {

diff --git a/src/Exception/InvalidIndentStyleException.php b/src/Exception/InvalidIndentStyleException.php
@@ -18,12 +18,12 @@ final class InvalidIndentStyleException extends \InvalidArgumentException implem
     /**
      * @var string
      */
-    private $style;
+    private $style = '';
 
     /**
      * @var string[]
      */
-    private $allowedStyles;
+    private $allowedStyles = [];
 
     public static function fromStyleAndAllowedStyles(string $style, string ...$allowedStyles): self
     {

diff --git a/src/Exception/InvalidJsonEncodeOptionsException.php b/src/Exception/InvalidJsonEncodeOptionsException.php
@@ -18,7 +18,7 @@ final class InvalidJsonEncodeOptionsException extends \InvalidArgumentException
     /**
      * @var int
      */
-    private $jsonEncodeOptions;
+    private $jsonEncodeOptions = 0;
 
     public static function fromJsonEncodeOptions(int $jsonEncodeOptions): self
     {

diff --git a/src/Exception/InvalidJsonEncodedException.php b/src/Exception/InvalidJsonEncodedException.php
@@ -18,7 +18,7 @@ final class InvalidJsonEncodedException extends \InvalidArgumentException implem
     /**
      * @var string
      */
-    private $encoded;
+    private $encoded = '';
 
     public static function fromEncoded(string $encoded): self
     {

diff --git a/src/Exception/InvalidNewLineStringException.php b/src/Exception/InvalidNewLineStringException.php
@@ -18,7 +18,7 @@ final class InvalidNewLineStringException extends \InvalidArgumentException impl
     /**
      * @var string
      */
-    private $string;
+    private $string = '';
 
     public static function fromString(string $string): self
     {

diff --git a/src/Exception/NormalizedInvalidAccordingToSchemaException.php b/src/Exception/NormalizedInvalidAccordingToSchemaException.php
@@ -18,7 +18,7 @@ final class NormalizedInvalidAccordingToSchemaException extends \RuntimeExceptio
     /**
      * @var string
      */
-    private $schemaUri;
+    private $schemaUri = '';
 
     public static function fromSchemaUri(string $schemaUri): self
     {

diff --git a/src/Exception/OriginalInvalidAccordingToSchemaException.php b/src/Exception/OriginalInvalidAccordingToSchemaException.php
@@ -18,7 +18,7 @@ final class OriginalInvalidAccordingToSchemaException extends \RuntimeException
     /**
      * @var string
      */
-    private $schemaUri;
+    private $schemaUri = '';
 
     public static function fromSchemaUri(string $schemaUri): self
     {

diff --git a/src/Exception/SchemaUriCouldNotBeReadException.php b/src/Exception/SchemaUriCouldNotBeReadException.php
@@ -18,7 +18,7 @@ final class SchemaUriCouldNotBeReadException extends \RuntimeException implement
     /**
      * @var string
      */
-    private $schemaUri;
+    private $schemaUri = '';
 
     public static function fromSchemaUri(string $schemaUri): self
     {

diff --git a/src/Exception/SchemaUriCouldNotBeResolvedException.php b/src/Exception/SchemaUriCouldNotBeResolvedException.php
@@ -18,7 +18,7 @@ final class SchemaUriCouldNotBeResolvedException extends \RuntimeException imple
     /**
      * @var string
      */
-    private $schemaUri;
+    private $schemaUri = '';
 
     public static function fromSchemaUri(string $schemaUri): self
     {

diff --git a/src/Exception/SchemaUriReferencesDocumentWithInvalidMediaTypeException.php b/src/Exception/SchemaUriReferencesDocumentWithInvalidMediaTypeException.php
@@ -18,7 +18,7 @@ final class SchemaUriReferencesDocumentWithInvalidMediaTypeException extends \Ru
     /**
      * @var string
      */
-    private $schemaUri;
+    private $schemaUri = '';
 
     public static function fromSchemaUri(string $schemaUri): self
     {

diff --git a/src/Exception/SchemaUriReferencesInvalidJsonDocumentException.php b/src/Exception/SchemaUriReferencesInvalidJsonDocumentException.php
@@ -18,7 +18,7 @@ final class SchemaUriReferencesInvalidJsonDocumentException extends \RuntimeExce
     /**
      * @var string
      */
-    private $schemaUri;
+    private $schemaUri = '';
 
     public static function fromSchemaUri(string $schemaUri): self
     {

diff --git a/test/Unit/Exception/InvalidIndentSizeExceptionTest.php b/test/Unit/Exception/InvalidIndentSizeExceptionTest.php
@@ -22,6 +22,14 @@
  */
 final class InvalidIndentSizeExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new InvalidIndentSizeException();
+
+        self::assertSame(0, $exception->minimumSize());
+        self::assertSame(0, $exception->size());
+    }
+
     public function testFromSizeAndMinimumSizeReturnsInvalidIndentSizeException(): void
     {
         $faker = self::faker();

diff --git a/test/Unit/Exception/InvalidIndentStringExceptionTest.php b/test/Unit/Exception/InvalidIndentStringExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class InvalidIndentStringExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new InvalidIndentStringException();
+
+        self::assertSame('', $exception->string());
+    }
+
     public function testFromSizeAndMinimumSizeReturnsInvalidIndentStringException(): void
     {
         $string = self::faker()->word;

diff --git a/test/Unit/Exception/InvalidIndentStyleExceptionTest.php b/test/Unit/Exception/InvalidIndentStyleExceptionTest.php
@@ -22,6 +22,14 @@
  */
 final class InvalidIndentStyleExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new InvalidIndentStyleException();
+
+        self::assertSame([], $exception->allowedStyles());
+        self::assertSame('', $exception->style());
+    }
+
     public function testExtendsInvalidArgumentException(): void
     {
         self::assertClassExtends(\InvalidArgumentException::class, InvalidIndentStyleException::class);

diff --git a/test/Unit/Exception/InvalidJsonEncodeOptionsExceptionTest.php b/test/Unit/Exception/InvalidJsonEncodeOptionsExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class InvalidJsonEncodeOptionsExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new InvalidJsonEncodeOptionsException();
+
+        self::assertSame(0, $exception->jsonEncodeOptions());
+    }
+
     public function testFromJsonEncodeOptionsReturnsInvalidJsonEncodeOptionsException(): void
     {
         $jsonEncodeOptions = self::faker()->randomNumber();

diff --git a/test/Unit/Exception/InvalidJsonEncodedExceptionTest.php b/test/Unit/Exception/InvalidJsonEncodedExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class InvalidJsonEncodedExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new InvalidJsonEncodedException();
+
+        self::assertSame('', $exception->encoded());
+    }
+
     public function testFromEncodedReturnsInvalidJsonEncodedException(): void
     {
         $encoded = self::faker()->sentence;

diff --git a/test/Unit/Exception/InvalidNewLineStringExceptionTest.php b/test/Unit/Exception/InvalidNewLineStringExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class InvalidNewLineStringExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new InvalidNewLineStringException();
+
+        self::assertSame('', $exception->string());
+    }
+
     public function testFromSizeAndMinimumSizeReturnsInvalidIndentStringException(): void
     {
         $string = self::faker()->word;

diff --git a/test/Unit/Exception/NormalizedInvalidAccordingToSchemaExceptionTest.php b/test/Unit/Exception/NormalizedInvalidAccordingToSchemaExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class NormalizedInvalidAccordingToSchemaExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new NormalizedInvalidAccordingToSchemaException();
+
+        self::assertSame('', $exception->schemaUri());
+    }
+
     public function testFromSchemaUriReturnsNormalizedInvalidAccordingToSchemaException(): void
     {
         $schemaUri = self::faker()->url;

diff --git a/test/Unit/Exception/OriginalInvalidAccordingToSchemaExceptionTest.php b/test/Unit/Exception/OriginalInvalidAccordingToSchemaExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class OriginalInvalidAccordingToSchemaExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new OriginalInvalidAccordingToSchemaException();
+
+        self::assertSame('', $exception->schemaUri());
+    }
+
     public function testFromSchemaUriReturnsOriginalInvalidAccordingToSchemaException(): void
     {
         $schemaUri = self::faker()->url;

diff --git a/test/Unit/Exception/SchemaUriCouldNotBeReadExceptionTest.php b/test/Unit/Exception/SchemaUriCouldNotBeReadExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class SchemaUriCouldNotBeReadExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new SchemaUriCouldNotBeReadException();
+
+        self::assertSame('', $exception->schemaUri());
+    }
+
     public function testFromSchemaUriReturnsSchemaUriCouldNotBeReadException(): void
     {
         $schemaUri = self::faker()->url;

diff --git a/test/Unit/Exception/SchemaUriCouldNotBeResolvedExceptionTest.php b/test/Unit/Exception/SchemaUriCouldNotBeResolvedExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class SchemaUriCouldNotBeResolvedExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new SchemaUriCouldNotBeResolvedException();
+
+        self::assertSame('', $exception->schemaUri());
+    }
+
     public function testFromSchemaUriReturnsSchemaUriCouldNotBeResolvedException(): void
     {
         $schemaUri = self::faker()->url;

diff --git a/test/Unit/Exception/SchemaUriReferencesDocumentWithInvalidMediaTypeExceptionTest.php b/test/Unit/Exception/SchemaUriReferencesDocumentWithInvalidMediaTypeExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class SchemaUriReferencesDocumentWithInvalidMediaTypeExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new SchemaUriReferencesDocumentWithInvalidMediaTypeException();
+
+        self::assertSame('', $exception->schemaUri());
+    }
+
     public function testFromSchemaUriReturnsSchemaUriReferencesDocumentWithInvalidMediaType(): void
     {
         $schemaUri = self::faker()->url;

diff --git a/test/Unit/Exception/SchemaUriReferencesInvalidJsonDocumentExceptionTest.php b/test/Unit/Exception/SchemaUriReferencesInvalidJsonDocumentExceptionTest.php
@@ -22,6 +22,13 @@
  */
 final class SchemaUriReferencesInvalidJsonDocumentExceptionTest extends AbstractExceptionTestCase
 {
+    public function testDefaults(): void
+    {
+        $exception = new SchemaUriReferencesInvalidJsonDocumentException();
+
+        self::assertSame('', $exception->schemaUri());
+    }
+
     public function testFromSchemaUriReturnsSchemaUriReferencesDocumentWithInvalidMediaType(): void
     {
         $schemaUri = self::faker()->url;