Fix: Handle empty namespace prefixes #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
json_decode
on PHP versions prior to 7.1💁♂️ According to https://getcomposer.org/doc/04-schema.md#psr-4 it's perfectly fine to use an empty namespace prefix as a fallback:
However, this is a problem with
json_encode()
on versions prior to PHP 7.1.See
Possible workarounds could be
json_decode($json, true)
, but has consequences when$json
contains empty objects/arrays as both will be interpreted as empty arrays