This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
reducing link width in closed ToC so the full border shows #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,7 +187,7 @@ currently these are TOC, History, and Search | |||
| .close & { | |||
| display: block; | |||
| border-right: none; | |||
| width: 40px; | |||
| width: 39px; | |||
There was a problem hiding this comment.
Magic numbers frighten me. Can we track down where the 40px came from, put that in a variable, and then use $that_var - 1 here? That'd explain the why much better, if that makes sense.
|
@cmc333333 not sure how much of a refactoring rabbit hole we want to go down right now but I defined a variable for the width of the parent container and did the minus - 1 thing for the piece inside. Ultimately though there are a lot of absolutely positioned elements with semi-arbitrary widths and positions that make up the nav that could use some cleaning up in the long term. |
|
@donjo gratzie . Every little bit helps! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The width of the ToC items was obscuring some of the border when the ToC was in the "closed" position.
to