-
Notifications
You must be signed in to change notification settings - Fork 39
#364: WHED appendix title handling rewritten to complement #359 #367
Conversation
@@ -11,7 +11,7 @@ | |||
from regparser.tree.depth import markers as mtypes | |||
from regparser.tree.depth import heuristics, rules | |||
from regparser.tree.depth.derive import derive_depths | |||
from regparser.tree.gpo_cfr.appendices import appendix_headers | |||
from regparser.tree.gpo_cfr import appendices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I attempted to only import the required function (get_appendix_title
) but my environment complained so I imported the entire module.
if titles: | ||
return titles[0].text | ||
else: | ||
return node.xpath("./RESERVED")[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced by get_appendix_title
.
Code looks good to me, though the linter's complaining that you need a newline above |
Thank you! Can you point me to how the project is linting code? |
Excellent, thanks! We're currently installing a bunch of flake8 plugins and then running |
Thanks @gregoryfoster ! |
Based on @cmc333333's comments on #365, I've added a
get_appendix_title
function toregparser/tree/gpo_cfr/appendices.py
, removedget_app_title
frominterpparser/gpo_cfr.py
, and replaced all references.