This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Allow pgsql filter threshold to be configured. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This threshold depends on the documents we're searching. It'd be helpful to allow an agency implementation to show all matches, for example.
| @@ -11,7 +12,7 @@ def matching_sections(search_args): | |||
| sections_query = Document.objects\ | |||
| .annotate(rank=SearchRank( | |||
| F('documentindex__search_vector'), SearchQuery(search_args.q)))\ | |||
| .filter(rank__gte=0.15)\ | |||
| .filter(rank__gt=settings.PG_SEARCH_RANK_CUTOFF)\ | |||
There was a problem hiding this comment.
Any particular reason to change from >= to >?
There was a problem hiding this comment.
Ah yes, I should have added that to the commit. The use case I was thinking of was returning all matches, regardless of particular ranking. Non-matches will have a rank of zero, so to achieve this goal we want to say match anything strictly greater than zero. We could simulate it with >= via 0.0000001 or what have you, but I figured this was a little cleaner.
tadhg-ohiggins
approved these changes
Aug 21, 2017
|
Thanks @tadhg-ohiggins . I'll bump the version number then merge. |
New features * #85 Ability to configure the search result match threshold in pgsql
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This threshold depends on the documents we're searching. It'd be helpful to
allow an agency implementation to show all matches, for example.