This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
37 CFR 1: markers in GPOTABLEs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoryfoster
commented
Apr 12, 2017
| <GPOTABLE CDEF="s30,8" COLS="2" OPTS="L0,tp0,p1,8/9,g1,t1"> | ||
| <ROW> | ||
| <ENT I="01">(i) A basic portion</ENT> | ||
| <ENT I="01">A basic portion</ENT> |
There was a problem hiding this comment.
Fixed by pulling the marker outside of the table, per @cmc333333's suggestion.
gregoryfoster
commented
Apr 12, 2017
| <GPOTABLE CDEF="s50,10" COLS="2" OPTS="L0,tp0,p0,8/9,g1,t1"> | ||
| <ROW> | ||
| <ENT>(j) [Reserved]</ENT> | ||
| </ROW> | ||
| <ROW> |
There was a problem hiding this comment.
Fixed by pushing the marker inside of the table.
There was a problem hiding this comment.
It might make more sense to pop (k), (l), etc. out in the long run as they're not addressable otherwise. Something to consider!
There was a problem hiding this comment.
Had to push it inside because (j) was the only marker at that level outside of a GPOTABLE.
|
👍 Looks good @gregoryfoster |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eregs/regulations-parserdoes not currently process regulatory markers found withinGPOTABLEobjects (see issue 368). This causes the parser to fail in circumstances where the depth of regulatory markers around aGPOTABLEobject cannot be accurately determined.This pull request fixes two of these errors found in the 37 CFR 1 2012 and 2013 annual editions.