Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function provider SPI #138

Closed
wants to merge 2 commits into from

Conversation

mbali
Copy link
Contributor

@mbali mbali commented Oct 18, 2022

The new FunctionProvider Service Provider Interface simplifies the extension of the function set provided by Stencil.

Implementing and registering these new implementations in META-INF/services/io.github.erdos.stencil.functions.FunctionProvider enable other libraries to register their functions automatically.

The new `FunctionProvider` Service Provider Interface simplifies the extension of the function set provided by Stencil.

Implementing and registering these new implementations in `META-INF/services/io.github.erdos.stencil.functions.FunctionProvider` enable other libraries to register their functions.
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #138 (e05ce09) into master (82c07c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          26       26           
  Lines        1904     1904           
  Branches      107      107           
=======================================
  Hits         1752     1752           
  Misses         45       45           
  Partials      107      107           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erdos erdos force-pushed the master branch 3 times, most recently from 2f5ea5f to a1a8cbb Compare November 19, 2023 12:56
@erdos erdos force-pushed the master branch 2 times, most recently from 68c7242 to ed46cf8 Compare July 22, 2024 16:27
@erdos erdos mentioned this pull request Jul 29, 2024
6 tasks
@erdos
Copy link
Owner

erdos commented Jul 29, 2024

Hey @mbali thanks for the thorough PR and your patience with it :-)

Because the code changed a lot on the master branch since the PR was opened, I reimplemented the functionality in #166 with some small changes:

  • The file in META-INF is automatically generated at compile time
  • Removed the priority() of function providers. Instead, to keep things simple, functions cannot be redefined with the same name.
  • Removed the customer namespace loading (ClojureCallFnProvider) - it is a nice addition to the framework, but it is preferred to adding it when we will have more concrete use cases.

The change goes live in version 0.6.1.

@erdos erdos marked this pull request as draft July 29, 2024 19:15
@erdos
Copy link
Owner

erdos commented Jul 30, 2024

Closing in favour of #166, feature is to be released in version 0.6.1.

@erdos erdos closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants