Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minOccurs and maxOccurs explicitly #22

Closed
wrygiel opened this issue Feb 10, 2017 · 0 comments
Closed

Use minOccurs and maxOccurs explicitly #22

wrygiel opened this issue Feb 10, 2017 · 0 comments

Comments

@wrygiel
Copy link
Contributor

wrygiel commented Feb 10, 2017

The default value of both minOccurs and maxOccurs is 1. In some of our XSDs we make use of this fact and skip defining these attributes.

However, this can lead to unintentional mistakes, like this one (in EMREX project). A developer may simply forget to properly fill out these attributes, because he is not required to do so when he introduces the new element.

So, it might be safer to make these attributes required in all our specs. Of course, they won't be required by the Schema, but they will be required by our own "project style guide".

wrygiel added a commit to erasmus-without-paper/ewp-specs-api-imobility-tors that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-ounits that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-institutions that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-iia-cnr that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-echo that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-discovery that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-courses that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-course-replication that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-architecture that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-omobilities that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-omobility-cnr that referenced this issue Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-specs-api-iias that referenced this issue Feb 10, 2017
@wrygiel wrygiel closed this as completed Feb 10, 2017
wrygiel added a commit to erasmus-without-paper/ewp-registry-service that referenced this issue Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant