Skip to content

Commit

Permalink
[Relay] fix small typekey issue (apache#1992)
Browse files Browse the repository at this point in the history
It might cause TupleTypeNode to be printed incorrectly.
it doesnt show in http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-1989/1/pipeline/141, but if you run it on local machine you will see what get compared being NodeBase and TupleType.

Also as a side thought can we write a giant macro that make sure everything get did right (all field get visited, typekey match, declare_node_type_info match, etc?) I can do some macro metaprogramming, so I can take up the work.
  • Loading branch information
MarisaKirisame authored and eqy committed Oct 29, 2018
1 parent 138de23 commit f02b538
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/tvm/relay/type.h
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ class TupleTypeNode : public TypeNode {

TVM_DLL static TupleType make(tvm::Array<Type> fields);

static constexpr const char* _type_key = "relay.TypeTuple";
static constexpr const char* _type_key = "relay.TupleType";
TVM_DECLARE_NODE_TYPE_INFO(TupleTypeNode, TypeNode);
};

Expand Down

0 comments on commit f02b538

Please sign in to comment.